Skip to content

Conversation

@jsoref
Copy link
Contributor

@jsoref jsoref commented Dec 4, 2025

Short description

codeql complains about https://github.com/check-spelling-sandbox/pdns/security/quality/rules/js%2Funused-local-variable

Unused variable, import, function or class

Unused local variables make code hard to read and understand. Any computation used to initialize an unused variable is wasted, which may lead to performance problems.

Similarly, unused imports and unused functions or classes can be confusing. They may even be a symptom of a bug caused, for example, by an incomplete refactoring.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • read and accepted the Developer Certificate of Origin document, including the AI Policy, and added a "Signed-off-by" to my commits
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

This matches the pattern from the examples:
https://github.com/shutterstock/rickshaw/blob/0e0671e6fdd843b6b0ea881600804fc57667925d/examples/scaled.html#L83-L89

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 19937114032

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 76 unchanged lines in 16 files lost coverage.
  • Overall coverage decreased (-0.04%) to 73.093%

Files with Coverage Reduction New Missed Lines %
pdns/dnsdistdist/dnsdist.cc 2 70.73%
pdns/misc.cc 2 61.56%
pdns/recursordist/aggressive_nsec.cc 2 66.39%
pdns/recursordist/lwres.cc 2 66.17%
pdns/recursordist/rec-eventtrace.hh 2 57.01%
pdns/misc.hh 3 85.03%
pdns/rcpgenerator.cc 3 90.63%
pdns/recursordist/recpacketcache.hh 3 89.55%
pdns/recursordist/syncres.cc 3 80.97%
pdns/remote_logger.cc 3 56.47%
Totals Coverage Status
Change from base Build 19934026199: -0.04%
Covered Lines: 128087
Relevant Lines: 164529

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants