dnsdist: Include a Date: response header for rejected HTTP1 requests #16375
+14
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miodvallat
reviewed
Oct 27, 2025
| struct tm tmval{}; | ||
| time_t timestamp = time(nullptr); | ||
| size_t len = strftime(data1.data(), data1.size(), dateformat.data(), gmtime_r(×tamp, &tmval)); | ||
| assert(len != 0); |
There was a problem hiding this comment.
Are you sure you want to keep that assert? Maybe simply skip the d_out.insert(..., data1)) in this case.
There was a problem hiding this comment.
I think I want to keep the assert, it means the buffer was too small. Getting a very clear message is better than having to debug why the Date header is missing.
Pull Request Test Coverage Report for Build 18837422702Details
💛 - Coveralls |
This allows OpenBSD ntpd time constraint retrieval to work properly with nghttp2 incoming DoH. Note that requests having no alpn data do not appear in any stats. Should that be changed? Signed-off-by: Otto Moerbeek <otto.moerbeek@open-xchange.com>
omoerbeek
force-pushed
the
dnsdist-http1-date-header
branch
from
6a49658 to
2f23fc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows OpenBSD ntpd time constraint retrieval to work properly with nghttp2 incoming DoH.
Note that requests having no alpn data do not appear in any stats. Should that be changed?
Short description
Checklist
I have: