auth: xfr churning

[miodvallat]

Short description

This is similar to the recent work on the 2136 code and not-merged-yet #16343: do more plumbing to pass more context, so that future structured logging has access to the information it needs (which is currently passed as a const string& logPrefix setup by the caller, which won't do in the world of structured logging).

So: plumbing, clang-tidy changes, some minor cleanup. Bo-ring.

Checklist

I have:

• read the CONTRIBUTING.md document
• read and accepted the Developer Certificate of Origin document, including the AI Policy, and added a "Signed-off-by" to my commits
• compiled this code
• tested this code
• included documentation (including possible behaviour changes)
• documented the code
• added or modified regression test(s)
• added or modified unit test(s)

[coveralls]

Pull Request Test Coverage Report for Build 18776176249

Details

• 186 of 264 (70.45%) changed or added relevant lines in 1 file are covered.
• 14471 unchanged lines in 217 files lost coverage.
• Overall coverage increased (+15.6%) to 73.028%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
pdns/auth-secondarycommunicator.cc	186	264	70.45%

Files with Coverage Reduction	New Missed Lines	%
modules/gsqlite3backend/gsqlite3backend.cc	1	95.45%
pdns/auth-caches.cc	1	66.67%
pdns/auth-catalogzone.hh	1	66.67%
pdns/auth-zonecache.hh	1	93.33%
pdns/backends/gsql/gsqlbackend.hh	1	98.88%
pdns/dnsdistdist/dnsdist-lua-network.cc	1	91.94%
pdns/dnsseckeeper.hh	1	62.5%
pdns/dnswriter.hh	1	76.6%
pdns/dynlistener.hh	1	0.0%
pdns/recursordist/validate-recursor.cc	1	64.94%

Totals
Change from base Build 18763150192:	15.6%
Covered Lines:	127487
Relevant Lines:	163878

---

💛 - Coveralls