Skip to content

Conversation

@pieterlexis
Copy link
Contributor

Short description

This draft-PR exists to see if we can build dnsdist in CI on arm64 as well.

Checklist

I have:

  • read the CONTRIBUTING.md document
  • read and accepted the Developer Certificate of Origin document, including the AI Policy, and added a "Signed-off-by" to my commits
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

@pieterlexis pieterlexis force-pushed the dnsdist-aarch64 branch 2 times, most recently from d5cb197 to b056afe Compare October 23, 2025 16:10
@pieterlexis
Copy link
Contributor Author

WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested

Discussion: Do we want to create an arm64 powerdns/base-pdns-ci-image/debian-12-pdns-base image?

CC: @romeroalx and @aerique as I expect them to be the ones maintaining those

@coveralls
Copy link

coveralls commented Oct 23, 2025

Pull Request Test Coverage Report for Build 18834649492

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 55 unchanged lines in 15 files lost coverage.
  • Overall coverage increased (+4.2%) to 73.012%

Files with Coverage Reduction New Missed Lines %
pdns/dnsdistdist/dnsdist-ipcrypt2.hh 1 50.0%
pdns/recursordist/recursor_cache.cc 1 81.66%
pdns/recursordist/rec-eventtrace.hh 2 50.25%
pdns/sstuff.hh 2 62.02%
modules/gpgsqlbackend/spgsql.cc 3 67.94%
pdns/iputils.hh 3 77.03%
pdns/opensslsigners.cc 3 61.27%
pdns/recursordist/recpacketcache.hh 3 89.55%
pdns/stubresolver.cc 3 77.02%
pdns/tsigverifier.cc 3 77.22%
Totals Coverage Status
Change from base Build 18747476088: 4.2%
Covered Lines: 127456
Relevant Lines: 163860

💛 - Coveralls

@romeroalx
Copy link
Member

WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested

Discussion: Do we want to create an arm64 powerdns/base-pdns-ci-image/debian-12-pdns-base image?

CC: @romeroalx and @aerique as I expect them to be the ones maintaining those

Yes, makes sense. I'm preparing a PR making the base image multi-arch

@romeroalx
Copy link
Member

WARNING: The requested image's platform (linux/amd64) does not match the detected host platform (linux/arm64/v8) and no specific platform was requested

Discussion: Do we want to create an arm64 powerdns/base-pdns-ci-image/debian-12-pdns-base image?
CC: @romeroalx and @aerique as I expect them to be the ones maintaining those

Yes, makes sense. I'm preparing a PR making the base image multi-arch

@pieterlexis Images are now available for both amd64 and arm64

@pieterlexis
Copy link
Contributor Author

Thanks Alexis, I've restarted the workflow to see what else I'd need to fix to make this happen!

@pieterlexis pieterlexis marked this pull request as ready for review October 27, 2025 12:16
@pieterlexis pieterlexis added this to the dnsdist-2.1.0 milestone Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants