Skip to content

Conversation

Habbie
Copy link
Member

@Habbie Habbie commented Aug 21, 2025

Short description

fixes #15141

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)
  • checked that this code was merged to master

@Habbie
Copy link
Member Author

Habbie commented Aug 21, 2025

Note that the two files are (now) identical. Perhaps we can symlink one?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 17129807640

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 27 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.008%) to 65.961%

Files with Coverage Reduction New Missed Lines %
pdns/recursordist/aggressive_nsec.cc 2 66.02%
pdns/iputils.cc 3 56.03%
pdns/opensslsigners.cc 3 61.34%
pdns/recursordist/syncres.cc 3 80.86%
pdns/tsigverifier.cc 3 77.22%
pdns/dnsdistdist/dnsdist-tcp.cc 4 77.59%
pdns/dnsrecords.cc 4 80.14%
pdns/recursordist/rec-tcp.cc 5 65.47%
Totals Coverage Status
Change from base Build 17129345394: 0.008%
Covered Lines: 127968
Relevant Lines: 165404

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please update signing keys to not use SHA1
3 participants