Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rec: fix a difference between record-cache hit and miss in some ServFail results #14822

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

omoerbeek
Copy link
Member

Short description

Specifically when the max CNAME chain length is exceeded (with QName Minimization enabled), but there are likely other cases.

Fixes #14310

Checklist

I have:

  • read the CONTRIBUTING.md document
  • compiled this code
  • tested this code
  • included documentation (including possible behaviour changes)
  • documented the code
  • added or modified regression test(s)
  • added or modified unit test(s)

Fixes PowerDNS#14310

Should be checked for unwanted side-effects, which is pretty tricky.
@omoerbeek omoerbeek added this to the rec-5.2.0 milestone Nov 5, 2024
@coveralls
Copy link

coveralls commented Nov 5, 2024

Pull Request Test Coverage Report for Build 11686424851

Details

  • 13 of 13 (100.0%) changed or added relevant lines in 2 files are covered.
  • 5225 unchanged lines in 76 files lost coverage.
  • Overall coverage decreased (-0.06%) to 64.634%

Files with Coverage Reduction New Missed Lines %
pdns/webserver.hh 1 69.16%
pdns/recursordist/sortlist.hh 1 75.0%
pdns/iputils.hh 1 78.25%
pdns/dnstap.cc 2 70.97%
ext/probds/murmur3.cc 2 94.12%
pdns/sstuff.hh 2 56.83%
pdns/dnsname.hh 2 91.68%
pdns/opensslsigners.cc 2 61.07%
pdns/recursordist/secpoll-recursor.cc 2 51.02%
pdns/rcpgenerator.cc 2 89.77%
Totals Coverage Status
Change from base Build 11681769272: -0.06%
Covered Lines: 125342
Relevant Lines: 163095

💛 - Coveralls

@omoerbeek omoerbeek merged commit 5f67fe3 into PowerDNS:master Nov 8, 2024
78 checks passed
@omoerbeek omoerbeek deleted the rec-chain-14310 branch November 8, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rec: too long CNAME chains ServFail results vary
3 participants