CI: build binaries for linux and macOS #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wojas
changed the title
Habbie
approved these changes
Mar 24, 2023
Artifacts are always put in a zip file.
Habbie
approved these changes
Mar 24, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking if we can build binaries for Linux (amd64) and macOS (amd64 and arm64).
Since LS uses CGo for the LMDB bindings, cross compiling is more complicated. Perhaps we can use docker's support for running in qemu?
The macOS ones may be of limited value, because they are not signed. Running them may be more of a hassle than compiling them yourself for most users. Perhaps add to homebrew instead?