Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor COMMON_APP_CONFIG for improved readability and maintainability——src/environment.ts #434

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
lab3
  • Loading branch information
“1626216058@qq.com” committed Nov 4, 2024
commit 3eb090f0495d319b25136493a9643b6a38983310
10 changes: 4 additions & 6 deletions src/environment.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
const variables = {
GITHUB_ORANIZATION_NAME: 'postcatlab',
GITHUB_PROJECT_NAME: 'postcat'
};
const GITHUB_ORGANIZATION_NAME = 'postcatlab';
const GITHUB_PROJECT_NAME = 'postcat';

export const COMMON_APP_CONFIG = {
// EXTENSION_URL: 'http://localhost:5000',
Expand All @@ -10,8 +8,8 @@ export const COMMON_APP_CONFIG = {
// SOCKET_PORT: '',
// MOCK_URL: 'http://8.219.85.124:5000',
NODE_SERVER_PORT: 4201,
GITHUB_ORANIZATION_NAME: variables.GITHUB_ORANIZATION_NAME,
GITHUB_PROJECT_NAME: variables.GITHUB_PROJECT_NAME,
GITHUB_ORANIZATION_NAME,
GITHUB_PROJECT_NAME,
GITHUB_REPO_URL: `https://github.com/${variables.GITHUB_ORANIZATION_NAME}/${variables.GITHUB_PROJECT_NAME}`,
BASE_DOWNLOAD_URL: 'https://data.postcat.com/download/'
// BASE_DOWNLOAD_URL: 'http://127.0.0.1:8080'
Expand Down