Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(correlation): Enable person-on-events querying #9952

Merged
merged 6 commits into from
May 26, 2022
Merged

feat(correlation): Enable person-on-events querying #9952

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
48b357b
wip
neilkakkar May 24, 2022
4854ea0
update
neilkakkar May 24, 2022
dbf5ef5
merge
neilkakkar May 25, 2022
d859b41
simplify
neilkakkar May 25, 2022
3fe5fd6
clean
neilkakkar May 25, 2022
690bbd6
address comment
neilkakkar May 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
merge
  • Loading branch information
@neilkakkar
neilkakkar committed May 25, 2022
commit dbf5ef5ab5c80b6288677518d653762a8802b788
1 change: 1 addition & 0 deletions ee/clickhouse/queries/funnels/funnel_correlation_persons.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ def actor_query(self, limit_actors: Optional[bool] = True):
person_properties_mode=PersonPropertiesMode.DIRECT_ON_EVENTS
if self._team.actor_on_events_querying_enabled
else PersonPropertiesMode.USING_PERSON_PROPERTIES_COLUMN,
person_id_joined_alias=f"{event_query.DISTINCT_ID_TABLE_ALIAS if not self._team.actor_on_events_querying_enabled else event_query.EVENT_TABLE_ALIAS}.person_id",
)

conversion_filter = (
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.