-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(exports): Dashboard / Insight exporting #9830
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't run it yet so apologies if there are some incorrect assumptions in comments
Overall this is really cool 💖
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gave it a first look, left some thoughts! Overall, 🤩.
While I got one export, I managed to get stuck in a state where the next ones didn't download. I'm not sure why, as I didn't really see any debug output.
This could be on my setup somehow as well, e.g. Chrome being flakey.
However it's a bit weird that the toast disappears for a while, and only later the export succeeds. Could we keep the toast around until either a success or failure is detected... or the user closes it themselves?
Somewhere along the way it seems i really screwed up this branch. There are bunch of changed files that I didn't change... Need to figure out what happened and somehow revert |
0a606e7
to
57eb8c6
Compare
Corrected Insight export styling
…sthog into feature/exporting-poc
# Conflicts: # cypress/integration/trends.js # latest_migrations.manifest
# Conflicts: # frontend/src/lib/constants.tsx
Added separator
Problem
See #9759 for more info
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?
Outstanding tasks
Misc
Closes #9851
Also closes #9799