Skip to content

chore(ci): read python pin from pyproject.toml instead of hardcoding per workflow #59478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rnegron wants to merge 1 commit into from
Closed

chore(ci): read python pin from pyproject.toml instead of hardcoding per workflow #59478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build-hogql-parser.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ jobs:

- uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0
with:
python-version: '3.12.10' # There is no 3.12.11/3.12.12 binary for mac/darwin architectures yet
python-version-file: 'pyproject.toml'

- name: Build sdist
if: matrix.os == 'ubuntu-22.04' # Only build the sdist once
Expand Down Expand Up @@ -176,7 +176,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0
with:
python-version: 3.12.12
python-version-file: 'pyproject.toml'

- name: Install uv
id: setup-uv
Expand Down
27 changes: 16 additions & 11 deletions .github/workflows/ci-backend.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0
with:
python-version: 3.12.12
python-version-file: 'pyproject.toml'
token: ${{ secrets.POSTHOG_BOT_PAT }}

- name: Install uv
Expand Down Expand Up @@ -537,7 +537,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0
with:
python-version: 3.12.12
python-version-file: 'pyproject.toml'

- name: Install uv
uses: astral-sh/setup-uv@37802adc94f370d6bfd71619e3f0bf239e1f3b78 # v7.6.0
Expand Down Expand Up @@ -666,7 +666,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0
with:
python-version: 3.12.12
python-version-file: 'pyproject.toml'

- name: Install uv
id: setup-uv
Expand Down Expand Up @@ -1380,6 +1380,10 @@ jobs:
outputs:
include: ${{ steps.build.outputs.include }}
steps:
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
with:
fetch-depth: 1

- name: Build matrix include list
id: build
env:
Expand All @@ -1388,11 +1392,12 @@ jobs:
run: |
# :NOTE: Keep shard counts/group ranges in sync with historical Django matrix tuning.
# Consult #team-devex before changing.
core=$(jq -cn --arg image "$OLDEST_SUPPORTED_IMAGE" '
python_version=$(grep -E '^requires-python\s*=' pyproject.toml | grep -oE '[0-9]+\.[0-9]+\.[0-9]+')
core=$(jq -cn --arg image "$OLDEST_SUPPORTED_IMAGE" --arg pv "$python_version" '
[range(1; 39) | {
segment: "Core",
"person-on-events": false,
"python-version": "3.12.12",
"python-version": $pv,
"clickhouse-server-image": $image,
concurrency: 38,
group: .,
Expand All @@ -1401,11 +1406,11 @@ jobs:
}]
')

core_persons_on_events=$(jq -cn --arg image "$OLDEST_SUPPORTED_IMAGE" '
core_persons_on_events=$(jq -cn --arg image "$OLDEST_SUPPORTED_IMAGE" --arg pv "$python_version" '
[range(1; 8) | {
segment: "Core",
"person-on-events": true,
"python-version": "3.12.12",
"python-version": $pv,
"clickhouse-server-image": $image,
concurrency: 7,
group: .,
Expand All @@ -1414,11 +1419,11 @@ jobs:
}]
')

temporal=$(jq -cn --arg image "$OLDEST_SUPPORTED_IMAGE" '
temporal=$(jq -cn --arg image "$OLDEST_SUPPORTED_IMAGE" --arg pv "$python_version" '
[range(1; 8) | {
segment: "Temporal",
"person-on-events": false,
"python-version": "3.12.12",
"python-version": $pv,
"clickhouse-server-image": $image,
concurrency: 7,
group: .,
Expand All @@ -1428,14 +1433,14 @@ jobs:
')

compat_source="${COMPAT_MATRIX_JSON:-[]}"
compat=$(jq -cn --argjson compat "$compat_source" '
compat=$(jq -cn --argjson compat "$compat_source" --arg pv "$python_version" '
[
$compat
| to_entries[]
| .value + {
segment: "Core",
"person-on-events": false,
"python-version": "3.12.12",
"python-version": $pv,
compat: true,
artifact_key: ("compat-" + ((.key + 1)|tostring))
}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-clickhouse-multinode-migrations.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0
with:
python-version: 3.12.12
python-version-file: 'pyproject.toml'

- name: Install uv
uses: astral-sh/setup-uv@37802adc94f370d6bfd71619e3f0bf239e1f3b78 # v7.6.0
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-e2e-playwright.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,7 +314,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0
with:
python-version: 3.12.12
python-version-file: 'pyproject.toml'

- name: Install uv
id: setup-uv
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-llm-gateway.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0
with:
python-version: '3.12'
python-version-file: 'services/llm-gateway/pyproject.toml'

- name: Install uv
uses: astral-sh/setup-uv@37802adc94f370d6bfd71619e3f0bf239e1f3b78 # v7.6.0
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci-mcp.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0
with:
python-version: 3.12.12
python-version-file: 'pyproject.toml'

- name: Install uv
uses: astral-sh/setup-uv@37802adc94f370d6bfd71619e3f0bf239e1f3b78 # v7.6.0
Expand Down Expand Up @@ -318,7 +318,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0
with:
python-version: 3.12.12
python-version-file: 'pyproject.toml'

- name: Install uv
uses: astral-sh/setup-uv@37802adc94f370d6bfd71619e3f0bf239e1f3b78 # v7.6.0
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-proto.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ jobs:

- uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0
with:
python-version: '3.12'
python-version-file: 'pyproject.toml'

- name: Install codegen tools
run: pip install grpcio-tools protoletariat ruff
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/ci-python.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0
with:
python-version: 3.12.12
python-version-file: 'pyproject.toml'

- name: Install uv
id: setup-uv
Expand Down Expand Up @@ -149,9 +149,9 @@ jobs:
uses: actions/cache/restore@cdf6c1fa76f9f475f3d7449005a359c84ca0f306 # v5.0.3
with:
path: .mypy_cache
key: mypy-cache-${{ runner.os }}-3.12-mypy2-${{ hashFiles('**/pyproject.toml', '**/mypy.ini') }}
key: mypy-cache-${{ runner.os }}-3.13-mypy2-${{ hashFiles('**/pyproject.toml', '**/mypy.ini') }}
restore-keys: |
mypy-cache-${{ runner.os }}-3.12-mypy2-
mypy-cache-${{ runner.os }}-3.13-mypy2-

- name: Check static typing
shell: bash -e {0}
Expand All @@ -165,7 +165,7 @@ jobs:
uses: actions/cache/save@cdf6c1fa76f9f475f3d7449005a359c84ca0f306 # v5.0.3
with:
path: .mypy_cache
key: mypy-cache-${{ runner.os }}-3.12-mypy2-${{ hashFiles('**/pyproject.toml', '**/mypy.ini') }}
key: mypy-cache-${{ runner.os }}-3.13-mypy2-${{ hashFiles('**/pyproject.toml', '**/mypy.ini') }}

- name: Check if "schema.py" is up to date
shell: bash
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-rust-flags-integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0
with:
python-version: '3.12.12'
python-version-file: 'pyproject.toml'

- name: Install uv
uses: astral-sh/setup-uv@37802adc94f370d6bfd71619e3f0bf239e1f3b78 # v7.6.0
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish-hogli.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:

- uses: actions/setup-python@a309ff8b426b58ec0e2a45f0f869d46889d02405 # v6.2.0
with:
python-version: '3.12'
python-version-file: 'tools/hogli/pyproject.toml'

- uses: astral-sh/setup-uv@37802adc94f370d6bfd71619e3f0bf239e1f3b78 # v7.6.0
with:
Expand Down
Loading