Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Breakdown limit customizable and Allow empty breakdown value in trends and funnels #5357

Merged
merged 12 commits into from
Aug 3, 2021
Merged

Make Breakdown limit customizable and Allow empty breakdown value in trends and funnels #5357

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c3068a5
breakdown limits update
neilkakkar Jul 28, 2021
f0e7125
include null in limit
neilkakkar Jul 28, 2021
5a237e3
indent
neilkakkar Jul 28, 2021
8808f63
general solution for funnels, trends to come
neilkakkar Jul 28, 2021
ff53a83
wip 1
neilkakkar Jul 28, 2021
4b3c59f
clean breakdowns for trends & peeps
neilkakkar Jul 28, 2021
08349c3
clean up frontend persons situation
neilkakkar Jul 29, 2021
33788b0
cleanup
neilkakkar Jul 29, 2021
16e111d
make none breakdowns work for funnels
neilkakkar Jul 29, 2021
0313e5a
fix labels in steps table
neilkakkar Jul 29, 2021
e6f13a0
rm logs
neilkakkar Jul 30, 2021
959dbd5
resolve merge conflicts
neilkakkar Aug 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
resolve merge conflicts
  • Loading branch information
@neilkakkar
neilkakkar committed Aug 2, 2021
commit 959dbd583278b8b5fdd85292047218b35b183a1d
1 change: 1 addition & 0 deletions frontend/src/scenes/funnels/funnelLogic.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ export const cleanFunnelParams = (filters: Partial<FilterType>, discardFiltersNo
...(filters.funnel_step_breakdown !== undefined
? { funnel_step_breakdown: filters.funnel_step_breakdown }
: {}),
...(filters.bin_count && filters.bin_count !== BinCountAuto ? { bin_count: filters.bin_count } : {}),
interval: autocorrectInterval(filters),
breakdown: breakdownEnabled ? filters.breakdown || undefined : undefined,
breakdown_type: breakdownEnabled ? filters.breakdown_type || undefined : undefined,
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.