Resolve caching issues with persons breakdown

ee/clickhouse/views/test/test_clickhouse_funnel_person.py

@@ -141,3 +141,88 @@ def test_basic_pagination_with_deleted(self, delete_person_patch):
         people = j["results"][0]["people"]
         self.assertEqual(0, len(people))
         self.assertEqual(None, j["next"])
+
+    def test_breakdowns(self):
+        request_data = {
+            "insight": INSIGHT_FUNNELS,
+            "interval": "day",
+            "actions": json.dumps([]),
+            "properties": json.dumps([]),
+            "funnel_step": 1,
+            "filter_test_accounts": "false",
+            "new_entity": json.dumps([]),
+            "events": json.dumps(
+                [{"id": "sign up", "order": 0}, {"id": "play movie", "order": 1}, {"id": "buy", "order": 2},]
+            ),
+            "insight": INSIGHT_FUNNELS,
+            "date_from": "2020-01-01",
+            "date_to": "2020-01-08",
+            "funnel_window_days": 7,
+            "breakdown": "$browser",
+            "funnel_step_breakdown": "Chrome",
+        }
+
+        # event
+        person1 = _create_person(distinct_ids=["person1"], team_id=self.team.pk)
+        _create_event(
+            team=self.team,
+            event="sign up",
+            distinct_id="person1",
+            properties={"key": "val", "$browser": "Chrome"},
+            timestamp="2020-01-01T12:00:00Z",
+        )
+        _create_event(
+            team=self.team,
+            event="play movie",
+            distinct_id="person1",
+            properties={"key": "val", "$browser": "Chrome"},
+            timestamp="2020-01-01T13:00:00Z",
+        )
+        _create_event(
+            team=self.team,
+            event="buy",
+            distinct_id="person1",
+            properties={"key": "val", "$browser": "Chrome"},
+            timestamp="2020-01-01T15:00:00Z",
+        )
+
+        person2 = _create_person(distinct_ids=["person2"], team_id=self.team.pk)
+        _create_event(
+            team=self.team,
+            event="sign up",
+            distinct_id="person2",
+            properties={"key": "val", "$browser": "Safari"},
+            timestamp="2020-01-02T14:00:00Z",
+        )
+        _create_event(
+            team=self.team,
+            event="play movie",
+            distinct_id="person2",
+            properties={"key": "val", "$browser": "Safari"},
+            timestamp="2020-01-02T16:00:00Z",
+        )
+
+        person3 = _create_person(distinct_ids=["person3"], team_id=self.team.pk)
+        _create_event(
+            team=self.team,
+            event="sign up",
+            distinct_id="person3",
+            properties={"key": "val", "$browser": "Safari"},
+            timestamp="2020-01-02T14:00:00Z",
+        )
+
+        response = self.client.get("/api/person/funnel/", data=request_data)
+        self.assertEqual(response.status_code, status.HTTP_200_OK)
+        j = response.json()
+
+        people = j["results"][0]["people"]
+        self.assertEqual(1, len(people))
+        self.assertEqual(None, j["next"])
+
+        response = self.client.get("/api/person/funnel/", data={**request_data, "funnel_step_breakdown": "Safari"})
+        self.assertEqual(response.status_code, status.HTTP_200_OK)
+        j = response.json()
+
+        people = j["results"][0]["people"]
+        self.assertEqual(2, len(people))
+        self.assertEqual(None, j["next"])

posthog/models/filters/mixins/funnel.py

@@ -92,7 +92,7 @@ def funnel_step_breakdown(self) -> Optional[Union[str, int]]:
         return self._data.get(FUNNEL_STEP_BREAKDOWN)
 
     @include_dict
-    def funnel_step_to_dict(self):
+    def funnel_person_breakdown_to_dict(self):
         return {FUNNEL_STEP_BREAKDOWN: self.funnel_step_breakdown} if self.funnel_step_breakdown else {}