Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle multiple same events in the funnel #4863

Merged
merged 7 commits into from
Jun 25, 2021
Merged

Handle multiple same events in the funnel #4863

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
905814a
dedup + tests
neilkakkar Jun 24, 2021
8a41f5a
deep equality. Tests to come
neilkakkar Jun 24, 2021
d64b58d
fjson dump is better
neilkakkar Jun 24, 2021
3d11ab6
write test for entity equality
neilkakkar Jun 25, 2021
20170c0
finish testing funnels
neilkakkar Jun 25, 2021
0bc8bd8
merge master, resolve conflicts
neilkakkar Jun 25, 2021
5819e03
clean up comments
neilkakkar Jun 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
clean up comments
  • Loading branch information
@neilkakkar
neilkakkar committed Jun 25, 2021
commit 5819e0335234b3eed8f088e55e958c08b7b29116
1 change: 0 additions & 1 deletion ee/clickhouse/queries/funnels/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ def _format_results(self, results):

for step in reversed(self._filter.entities):
# Clickhouse step order starts at one, hence the +1
# TODO(nk): Check if all steps coming in always have an order. This gets borked if not
result_step = [x for x in results if step.order + 1 == x[0]]
if len(result_step) > 0:
total_people += result_step[0][1]
Expand Down
1 change: 0 additions & 1 deletion posthog/models/entity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import json
from typing import Any, Dict, List, Optional, Union

from posthog.constants import TREND_FILTER_TYPE_ACTIONS, TREND_FILTER_TYPE_EVENTS
Expand Down