Skip to content

chore(ci): use docker compose profiles for Azurite instead of separate file #44990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
webjunkie merged 1 commit into from
Jan 14, 2026
Merged

chore(ci): use docker compose profiles for Azurite instead of separate file #44990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci-backend.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -705,8 +705,8 @@ jobs:
while [ $attempt -le $max_attempts ]; do
echo "Attempt $attempt of $max_attempts to start stack..."

if docker compose -f docker-compose.dev.yml -f products/batch_exports/backend/tests/docker-compose.yml down && \
docker compose -f docker-compose.dev.yml -f products/batch_exports/backend/tests/docker-compose.yml up -d; then
if docker compose -f docker-compose.dev.yml --profile '*' down && \
docker compose -f docker-compose.dev.yml --profile batch-exports up -d; then
echo "Stack started successfully"
exit 0
fi
Expand Down
8 changes: 8 additions & 0 deletions docker-compose.base.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,14 @@ services:
entrypoint: sh
command: -c 'mkdir -p /data/posthog /data/ducklake-dev /data/ai-blobs && minio server --address ":19000" --console-address ":19001" /data' # create the 'posthog', 'ducklake-dev', and 'ai-blobs' buckets before starting the service

objectstorage-azure:
image: mcr.microsoft.com/azure-storage/azurite:3.35.0
restart: on-failure
profiles: ['batch-exports']
command: azurite-blob --blobHost 0.0.0.0 --blobPort 10000 --location /data
ports:
- '10000:10000'
Comment on lines +199 to +205
Copy link

Copilot AI Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original docker-compose.yml file included container_name: posthog_azurite which is missing in this migration. This could cause issues if any scripts, tests, or documentation rely on this specific container name for connecting to or managing the Azurite service. Consider adding container_name: posthog_azurite to maintain compatibility.

Copilot uses AI. Check for mistakes.
Copy link
Contributor

@tomasfarias tomasfarias Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe good to do this, although shouldn't really change much.


maildev:
image: maildev/maildev:2.0.5
restart: on-failure
Expand Down
5 changes: 5 additions & 0 deletions docker-compose.dev.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,11 @@ services:
- '19000:19000'
- '19001:19001'

objectstorage-azure:
extends:
file: docker-compose.base.yml
service: objectstorage-azure

maildev:
extends:
file: docker-compose.base.yml
Expand Down
17 changes: 0 additions & 17 deletions products/batch_exports/backend/tests/docker-compose.yml
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion products/batch_exports/backend/tests/temporal/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ The Azurite emulator provides Azure Storage API compatibility locally. To run th
1. Ensure the development Docker stack is running (includes Azurite):

```bash
docker compose -f docker-compose.dev.yml -f products/batch_exports/backend/tests/docker-compose.yml up -d
docker compose -f docker-compose.dev.yml --profile batch-exports up -d
```

2. Run the tests from the root of the `posthog` repo:
Expand Down
Loading