fix(funnels): replace deprecated rust group_by - #42289
Merged
Merged
Conversation
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
thmsobrmlr
marked this pull request as ready for review
November 28, 2025 13:17
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
This was referenced Nov 28, 2025
gesh
approved these changes
Dec 1, 2025
aspicer
approved these changes
Dec 4, 2025
thmsobrmlr
changed the base branch from
feat_funnels_expose_faulty_inputs_when_parsing_args_in_udf
to
graphite-base/42289
December 4, 2025 10:02
thmsobrmlr
force-pushed
the
graphite-base/42289
branch
from
December 4, 2025 10:03
f16af8a to
c182023
Compare
thmsobrmlr
force-pushed
the
fix_funnels_replace_deprecated_rust_group_by
branch
from
December 4, 2025 10:03
809915b to
99f0ef8
Compare
thmsobrmlr
force-pushed
the
fix_funnels_replace_deprecated_rust_group_by
branch
from
December 4, 2025 10:04
99f0ef8 to
d13615b
Compare
Collaborator
Author
Merge activity
|
sakce
pushed a commit
that referenced
this pull request
Dec 5, 2025
## Problem "group by" was renamed to "chunk by" rust-lang/rust#117678 ``` warning: use of deprecated method itertools::Itertools::group_by: Use .chunk_by() instead --> src/steps.rs:125:14 | 125 | .group_by(|e| e.timestamp); | ^^^^^^^^ | = note: #[warn(deprecated)] on by default warning: use of deprecated method itertools::Itertools::group_by: Use .chunk_by() instead --> src/trends.rs:137:14 | 137 | .group_by(|e| e.timestamp); | ^^^^^^^^ ``` ## Changes Updates code usages. ## How did you test this code? CI run
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
"group by" was renamed to "chunk by" rust-lang/rust#117678
Changes
Updates code usages.
How did you test this code?
CI run