Skip to content

fix(batch-exports): Ensure external logs also get logged internally #38932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2025
+18 −18
Merged

fix(batch-exports): Ensure external logs also get logged internally #38932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions products/batch_exports/backend/temporal/batch_exports.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
from posthog.sync import database_sync_to_async
from posthog.temporal.common.clickhouse import ClickHouseClient
from posthog.temporal.common.client import connect
from posthog.temporal.common.logger import get_produce_only_logger, get_write_only_logger
from posthog.temporal.common.logger import get_logger, get_write_only_logger

from products.batch_exports.backend.temporal.metrics import get_export_finished_metric, get_export_started_metric
from products.batch_exports.backend.temporal.pipeline.types import BatchExportResult
Expand All @@ -52,7 +52,7 @@
from ee.billing.quota_limiting import QuotaLimitingCaches, QuotaResource, list_limited_team_attributes

LOGGER = get_write_only_logger(__name__)
EXTERNAL_LOGGER = get_produce_only_logger("EXTERNAL")
EXTERNAL_LOGGER = get_logger("EXTERNAL")

BytesGenerator = collections.abc.Generator[bytes, None, None]
RecordsGenerator = collections.abc.Generator[pa.RecordBatch, None, None]
Expand Down
4 changes: 2 additions & 2 deletions products/batch_exports/backend/temporal/destinations/bigquery_batch_export.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
)
from posthog.temporal.common.base import PostHogWorkflow
from posthog.temporal.common.heartbeat import Heartbeater
from posthog.temporal.common.logger import get_produce_only_logger, get_write_only_logger
from posthog.temporal.common.logger import get_logger, get_write_only_logger

from products.batch_exports.backend.temporal.batch_exports import (
FinishBatchExportRunInputs,
Expand Down Expand Up @@ -83,7 +83,7 @@
)

LOGGER = get_write_only_logger(__name__)
EXTERNAL_LOGGER = get_produce_only_logger("EXTERNAL")
EXTERNAL_LOGGER = get_logger("EXTERNAL")


class MissingRequiredPermissionsError(Exception):
Expand Down
4 changes: 2 additions & 2 deletions products/batch_exports/backend/temporal/destinations/databricks_batch_export.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
from posthog.models.integration import DatabricksIntegration, Integration
from posthog.temporal.common.base import PostHogWorkflow
from posthog.temporal.common.heartbeat import Heartbeater
from posthog.temporal.common.logger import get_produce_only_logger, get_write_only_logger
from posthog.temporal.common.logger import get_logger, get_write_only_logger

from products.batch_exports.backend.temporal.batch_exports import (
StartBatchExportRunInputs,
Expand All @@ -54,7 +54,7 @@
from products.batch_exports.backend.temporal.utils import JsonType, handle_non_retryable_errors

LOGGER = get_write_only_logger(__name__)
EXTERNAL_LOGGER = get_produce_only_logger("EXTERNAL")
EXTERNAL_LOGGER = get_logger("EXTERNAL")


NON_RETRYABLE_ERROR_TYPES: list[str] = [
Expand Down
4 changes: 2 additions & 2 deletions products/batch_exports/backend/temporal/destinations/postgres_batch_export.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
)
from posthog.temporal.common.base import PostHogWorkflow
from posthog.temporal.common.heartbeat import Heartbeater
from posthog.temporal.common.logger import get_produce_only_logger, get_write_only_logger
from posthog.temporal.common.logger import get_logger, get_write_only_logger

from products.batch_exports.backend.temporal.batch_exports import (
FinishBatchExportRunInputs,
Expand Down Expand Up @@ -72,7 +72,7 @@
)

LOGGER = get_write_only_logger(__name__)
EXTERNAL_LOGGER = get_produce_only_logger("EXTERNAL")
EXTERNAL_LOGGER = get_logger("EXTERNAL")

NON_RETRYABLE_ERROR_TYPES = (
# Raised on errors that are related to database operation.
Expand Down
4 changes: 2 additions & 2 deletions products/batch_exports/backend/temporal/destinations/redshift_batch_export.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
from posthog.batch_exports.service import BatchExportField, BatchExportModel, RedshiftBatchExportInputs
from posthog.temporal.common.base import PostHogWorkflow
from posthog.temporal.common.heartbeat import Heartbeater
from posthog.temporal.common.logger import get_produce_only_logger, get_write_only_logger
from posthog.temporal.common.logger import get_logger, get_write_only_logger

from products.batch_exports.backend.temporal.batch_exports import (
FinishBatchExportRunInputs,
Expand Down Expand Up @@ -56,7 +56,7 @@
)

LOGGER = get_write_only_logger(__name__)
EXTERNAL_LOGGER = get_produce_only_logger()
EXTERNAL_LOGGER = get_logger()


NON_RETRYABLE_ERROR_TYPES = (
Expand Down
4 changes: 2 additions & 2 deletions products/batch_exports/backend/temporal/destinations/s3_batch_export.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
from posthog.batch_exports.service import BatchExportField, BatchExportInsertInputs, S3BatchExportInputs
from posthog.temporal.common.base import PostHogWorkflow
from posthog.temporal.common.heartbeat import Heartbeater
from posthog.temporal.common.logger import get_produce_only_logger, get_write_only_logger
from posthog.temporal.common.logger import get_logger, get_write_only_logger

from products.batch_exports.backend.temporal.batch_exports import (
OverBillingLimitError,
Expand Down Expand Up @@ -77,7 +77,7 @@
}

LOGGER = get_write_only_logger(__name__)
EXTERNAL_LOGGER = get_produce_only_logger("EXTERNAL")
EXTERNAL_LOGGER = get_logger("EXTERNAL")


class UnsupportedFileFormatError(Exception):
Expand Down
4 changes: 2 additions & 2 deletions products/batch_exports/backend/temporal/destinations/snowflake_batch_export.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
)
from posthog.temporal.common.base import PostHogWorkflow
from posthog.temporal.common.heartbeat import Heartbeater
from posthog.temporal.common.logger import get_produce_only_logger, get_write_only_logger
from posthog.temporal.common.logger import get_logger, get_write_only_logger

from products.batch_exports.backend.temporal.batch_exports import (
FinishBatchExportRunInputs,
Expand Down Expand Up @@ -73,7 +73,7 @@
)

LOGGER = get_write_only_logger(__name__)
EXTERNAL_LOGGER = get_produce_only_logger("EXTERNAL")
EXTERNAL_LOGGER = get_logger("EXTERNAL")


class NamedBytesIO(io.BytesIO):
Expand Down
4 changes: 2 additions & 2 deletions products/batch_exports/backend/temporal/pipeline/consumer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
import pyarrow as pa
import temporalio.common

from posthog.temporal.common.logger import get_produce_only_logger, get_write_only_logger
from posthog.temporal.common.logger import get_logger, get_write_only_logger

from products.batch_exports.backend.temporal.metrics import get_bytes_exported_metric, get_rows_exported_metric
from products.batch_exports.backend.temporal.pipeline.transformer import get_stream_transformer
Expand All @@ -17,7 +17,7 @@
)

LOGGER = get_write_only_logger(__name__)
EXTERNAL_LOGGER = get_produce_only_logger("EXTERNAL")
EXTERNAL_LOGGER = get_logger("EXTERNAL")


class Consumer:
Expand Down
4 changes: 2 additions & 2 deletions products/batch_exports/backend/temporal/spmc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
from posthog.sync import database_sync_to_async
from posthog.temporal.common.clickhouse import get_client
from posthog.temporal.common.heartbeat import Heartbeater
from posthog.temporal.common.logger import get_produce_only_logger, get_write_only_logger
from posthog.temporal.common.logger import get_logger, get_write_only_logger

from products.batch_exports.backend.temporal.heartbeat import BatchExportRangeHeartbeatDetails, DateRange
from products.batch_exports.backend.temporal.metrics import get_bytes_exported_metric, get_rows_exported_metric
Expand Down Expand Up @@ -55,7 +55,7 @@
)

LOGGER = get_write_only_logger(__name__)
EXTERNAL_LOGGER = get_produce_only_logger("EXTERNAL")
EXTERNAL_LOGGER = get_logger("EXTERNAL")


class RecordBatchQueue(asyncio.Queue):
Expand Down
Loading