chore(data-warehouse): Update job and schema statuses #32704
+108
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR updates status enums in the data warehouse system to standardize naming conventions and prepare for billing limit features.
- Updates schema status
ErrortoFailedto match job status naming in/posthog/migrations/0743_dwh_model_statuses.py - Renames
Cancelledstatus toBillingLimitReachedacross schemas and jobs - Adds new
BillingLimitTooLowstatus for upcoming billing features - Migration is irreversible (uses
noopfor reverse SQL) which could make rollbacks challenging - Status field length constraints should be verified to accommodate longer status names
12 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
frontend/src/scenes/data-warehouse/settings/DataWarehouseManagedSourcesTable.tsx
Show resolved
Hide resolved
| @@ -26,7 +26,7 @@ def update_external_job_status( | |||
| model.save() | |||
|
|
|||
| if status == ExternalDataJob.Status.FAILED: | |||
| schema_status: ExternalDataSchema.Status = ExternalDataSchema.Status.ERROR | |||
| schema_status: ExternalDataSchema.Status = ExternalDataSchema.Status.FAILED | |||
| else: | |||
| schema_status = status # type: ignore | |||
There was a problem hiding this comment.
logic: Type ignore here is dangerous - should explicitly check if status is a valid schema status instead of relying on type coercion
Comment on lines
28
to
32
| if status == ExternalDataJob.Status.FAILED: | ||
| schema_status: ExternalDataSchema.Status = ExternalDataSchema.Status.ERROR | ||
| schema_status: ExternalDataSchema.Status = ExternalDataSchema.Status.FAILED | ||
| else: | ||
| schema_status = status # type: ignore | ||
|
|
There was a problem hiding this comment.
style: Consider handling other terminal states (like CANCELLED/BILLING_LIMITS_REACHED) explicitly rather than defaulting them
|
Size Change: +5 B (0%) Total Size: 3.72 MB ℹ️ View Unchanged
|
EDsCODE
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
statusenum for schemas and jobs to be more aligned:Errorto match the JobsFailedBilling Limits Too Lowfor upcoming PRHow did you test this code?
Checked frontend statuses