fix(err): make assignee select consistent #31185
Conversation
remove email fix typos
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR refactors the assignee selection and display components in the error tracking feature to create a more consistent and modular implementation.
- Moved and restructured components into a dedicated
components/Assignee/directory with clear separation of concerns - Implemented a render prop pattern in
AssigneeSelectfor more flexible UI customization - Created specialized components (
ResolvedAssigneeIconDisplay,ResolvedAssigneeLabelDisplay) for consistent rendering across different contexts - Added Storybook stories for visual testing of the
AssigneeDisplaycomponent in various states and sizes - Improved type definitions with more specific types (
UserAssignee,GroupAssignee,ResolvedAssignee) replacing the genericAssigneeDisplayType
12 file(s) reviewed, 6 comment(s)
Edit PR Review Bot Settings | Greptile
frontend/src/scenes/error-tracking/components/Assignee/AssigneeDisplay.tsx
Show resolved
Hide resolved
frontend/src/scenes/error-tracking/components/Assignee/AssigneeDisplay.tsx
Show resolved
Hide resolved
frontend/src/scenes/error-tracking/components/Assignee/AssigneeDisplay.tsx
Outdated
Show resolved
Hide resolved
frontend/src/scenes/error-tracking/components/Assignee/AssigneeDropdown.tsx
Outdated
Show resolved
Hide resolved
frontend/src/scenes/error-tracking/components/Assignee/AssigneeDropdown.tsx
Show resolved
Hide resolved
frontend/src/scenes/error-tracking/components/Assignee/AssigneeSelect.tsx
Outdated
Show resolved
Hide resolved
|
Size Change: +554 B (0%) Total Size: 13.6 MB ℹ️ View Unchanged
|
| labelClassname?: string | ||
| } | ||
|
|
||
| export const ResolvedAssigneeDisplay = ({ |
There was a problem hiding this comment.
Is there a better name than "resolved" it confused me for a while given we have the concept of "resolved" issues
There was a problem hiding this comment.
EnrichedAssignee ? DetailedAssignee ? FullAssignee ?
There was a problem hiding this comment.
"Known", maybe? Although it might not need an adjective at all - "AssigneeDisplay" seems good enough here?
There was a problem hiding this comment.
I wanted to differentiate the assignee in the issue from the one with full properties but let's keep it simple, I renamed it into Assignee
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
Problem
Changes
How did you test this code?