Skip to content

fix(editor): editor search docs #31181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025
Merged

fix(editor): editor search docs #31181

merged 1 commit into from
Apr 14, 2025

Conversation

kappa90
Copy link
Contributor

@kappa90 kappa90 commented Apr 14, 2025

Problem

The search_documentation tool in the editor is broken, as it doesn't need a system prompt. We also use the wrong model because Inkeep's docs are not updated.

Changes

  • Allow blank system prompt in the API request
  • Change Inkeep's model name

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

By calling the API locally.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR fixes the broken search_documentation tool in the editor by addressing issues with system prompts and model naming for the Inkeep integration.

  • Modified LLMProxyCompletionSerializer in products/editor/backend/api.py to allow blank system prompts with allow_blank=True
  • Updated Inkeep model name from 'inkeep-qa' to 'inkeep-qa-expert' in both files for consistency
  • Added model validation in InkeepProvider to check if the provided model ID is supported
  • Changed parameter name in stream_response method from '_' to 'system' to properly recognize the system parameter
  • Improved error handling in the Inkeep provider with specific error messages for API and unexpected errors

💡 (4/5) You can add custom instructions or style guidelines for the bot here!

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@kappa90 kappa90 requested review from joshsny and a team April 14, 2025 12:16
@kappa90 kappa90 merged commit 822c508 into master Apr 14, 2025
110 of 111 checks passed
@kappa90 kappa90 deleted the fix/editor-search-docs branch April 14, 2025 13:11
lricoy pushed a commit that referenced this pull request Apr 14, 2025
Co-authored-by: kappa90 <e.capparelli@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants