fix: Cyclotron vars #31178
Merged
fix: Cyclotron vars #31178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR refactors the Cyclotron configuration system to eliminate duplicated settings and improve type safety across multiple components.
- Moves
shouldCompressVmStateandshouldUseBulkJobCopyfrom individual pool/shard configs to the appropriate root level in both TypeScript and Rust implementations - Updates
@posthog/cyclotronfrom version 0.1.10 to 0.1.11 in both package.json files - Adds
#[serde(alias="...")]attributes in Rust to support camelCase JSON field names for better JS/TS integration - Restructures worker configuration by merging tuning parameters into a single configuration object
- Removes the now-unnecessary
CyclotronWorkerTuningConfigtype while maintaining backward compatibility
10 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
eli-r-ph
reviewed
Apr 14, 2025
| should_compress_vm_state, | ||
| should_use_bulk_job_copy, | ||
| ); | ||
| let manager = QueueManager::from_pool(db.clone(), should_compress_vm_state, false); | ||
|
|
There was a problem hiding this comment.
🤔 @benjackwhite should the bulk job copy be wired up here too?
There was a problem hiding this comment.
I got rid of it as it makes no sense. this is just a test so we dont want to modify our whole worker config to support something that the service itself never actually does
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The cyclotron config setup was completely borked due to duplicates all over the place. Attempted to simplify this with stronger typing
Changes
Does this work well for both Cloud and self-hosted?
How did you test this code?