chore: Revert "chore(err): temp disable quota limits" #31170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit df41095.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR reverts a previous change that temporarily disabled quota limits in the billing system, now that beta users have been properly assigned to the correct plans.
- Renamed parameter from
_contexttocontextinrust/cymbal/src/pipeline/billing.rsto indicate it's now being actively used - Uncommented the code block that checks if a token is limited based on billing plans
- Re-enables the quota limiting functionality that was previously disabled due to concerns about users not on any plan
- The change is now safe to implement since beta users have been properly assigned to correct billing plans
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
Let me circle back on this, I want to modify it slightly so the dropped events get reported in our metrics |
daibhin
changed the title
|
Actually, this is fine, merging |
oliverb123
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #30832
Should be ok to roll this out again now that any beta users are on the correct plan