Skip to content

fix: add dot notation mapping in data warehouse events override #31151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 14, 2025

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Apr 11, 2025

Problem

<!-- Who are we building for, what are their needs, why is this important? -->

Changes

  • consider mapping

Does this work well for both Cloud and self-hosted?

How did you test this code?

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR fixes an issue with dot notation in data warehouse events that broke insights after PR #30947 was merged.

  • Added warehouse_tables_dot_notation_mapping dictionary to track relationships between dot notation names (e.g., stripe.prefix.table_name) and original table names
  • Modified define_mappings function to use this mapping when looking up tables with data warehouse event modifiers
  • Added test case test_data_warehouse_events_modifiers_with_dot_notation to verify dot notation works correctly with warehouse tables
  • Ensures backward compatibility for existing insights that use dot-notated fields

Greptile AI

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@Gilbert09 Gilbert09 merged commit 6e96ff2 into master Apr 14, 2025
93 of 94 checks passed
@Gilbert09 Gilbert09 deleted the hogql-dot-notation-insights branch April 14, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants