chore: manual exception capture calls #31135

daibhin · 2025-04-11T16:34:17Z

More generic exception capture

greptile-apps

PR Summary

This PR centralizes exception handling by replacing direct Sentry SDK calls with PostHog's own exception capture implementation.

Modified posthog/exceptions_capture.py to remove Sentry integration, focusing solely on PostHog's analytics exception capture with a new properties parameter
Changed import sources across multiple files from sentry_sdk.capture_exception to a custom implementation in posthog.exceptions
Renamed parameter extras to properties in all capture_exception calls in RBAC migration files
Potential issue with import path in rbac_feature_flag_migration.py which may need to be a relative import from a PostHog module
Standardized exception capturing approach across the codebase while maintaining the same error handling functionality

_{6 file(s) reviewed, 4 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

greptile-apps · 2025-04-11T16:34:56Z

posthog/email.py

@@ -11,7 +11,7 @@
 from django.template.loader import get_template
 from django.utils import timezone
 from django.utils.module_loading import import_string
-from sentry_sdk import capture_exception
+from exceptions import capture_exception


logic: The import path from exceptions import capture_exception appears incorrect. Based on the context, this should likely be from posthog.exceptions_capture import capture_exception since 'exceptions' is not a standard Python module and the custom implementation is likely in the posthog package.

greptile-apps · 2025-04-11T16:34:59Z

posthog/api/organization.py

@@ -33,7 +33,7 @@
 from rest_framework.decorators import action
 from posthog.rbac.migrations.rbac_team_migration import rbac_team_access_control_migration
 from posthog.rbac.migrations.rbac_feature_flag_migration import rbac_feature_flag_role_access_migration
-from sentry_sdk import capture_exception
+from exceptions import capture_exception


logic: The import should be from posthog.exceptions_capture import capture_exception based on the file structure shown in the context. The current import path may cause import errors.

greptile-apps · 2025-04-11T16:35:05Z

posthog/rbac/migrations/rbac_feature_flag_migration.py

@@ -5,7 +5,7 @@
 from ee.models.rbac.role import Role
 from django.db import transaction
 import structlog
-from sentry_sdk import capture_exception
+from exceptions import capture_exception


logic: The import path 'exceptions' appears incorrect. Based on other files in the codebase, this should likely be 'posthog.exceptions_capture' or similar. An incorrect import path will cause the migration to fail when executed.

greptile-apps · 2025-04-11T16:36:33Z

posthog/rbac/migrations/rbac_team_migration.py

@@ -3,7 +3,7 @@
 from ee.models.explicit_team_membership import ExplicitTeamMembership
 import structlog
 from posthog.models.organization import Organization, OrganizationMembership
-from sentry_sdk import capture_exception
+from exceptions import capture_exception


logic: Import should be from posthog.exceptions_capture instead of just exceptions. This will likely cause an ImportError since there's no top-level exceptions module.

Suggested change

from exceptions import capture_exception

from posthog.exceptions import capture_exception

zlwaterfield

big moves

…alls

posthog-bot · 2025-04-11T17:39:05Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2025-04-11T17:48:05Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

github-actions · 2025-04-11T17:58:07Z

Size Change: -203 kB (-1.51%)

Total Size: 13.2 MB

Filename	Size	Change
`frontend/dist/toolbar.js`	13.2 MB	-203 kB (-1.51%)

_{compressed-size-action}

…alls

…ub.com:PostHog/posthog into dn-chore/update-manual-exception-capture-calls

posthog-bot · 2025-04-11T19:12:47Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

…alls

…ub.com:PostHog/posthog into dn-chore/update-manual-exception-capture-calls

daibhin · 2025-04-14T08:01:06Z

posthog/exceptions_capture.py

    from posthoganalytics import api_key, capture_exception as posthog_capture_exception
    import structlog

    logger = structlog.get_logger(__name__)

-    sentry_capture_exception(error, scope=sentry_scope, **sentry_scope_kwargs)


@dmarticus I dug a little further and it looks like removing this line is what is causing the number of query assertions to fail under the hood. Don't exactly know why but it feels like a pretty safe change to make. Going to update the test and merge this

hpouillot

Should we replace frontend/src/layout/ErrorBoundary/ErrorBoundary.tsx and get rid of unused deps as well ?

hpouillot · 2025-04-14T07:56:47Z

frontend/src/scenes/notebooks/Nodes/NotebookNodePlaylist.tsx

@@ -120,9 +120,9 @@ export const Settings = ({
    }

    return (
-        <ErrorBoundary>
+        <PostHogErrorBoundary>


chore: manual exception capture calls

3d332ff

daibhin requested review from zlwaterfield, a team, hpouillot and oliverb123 April 11, 2025 16:34

greptile-apps bot reviewed Apr 11, 2025

View reviewed changes

zlwaterfield approved these changes Apr 11, 2025

View reviewed changes

daibhin and others added 5 commits April 11, 2025 18:10

more changes

04be81d

fix import paths

db5b6ed

Merge branch 'master' into dn-chore/update-manual-exception-capture-c…

f10aa12

…alls

fix method props

7a2cefb

Update UI snapshots for chromium (2)

7b559d7

Update UI snapshots for chromium (2)

1b28d5e

daibhin and others added 5 commits April 11, 2025 19:46

correct import source

966a9d1

Merge branch 'master' into dn-chore/update-manual-exception-capture-c…

a831fcf

…alls

Merge branch 'dn-chore/update-manual-exception-capture-calls' of gith…

92d5d4f

…ub.com:PostHog/posthog into dn-chore/update-manual-exception-capture-calls

reduce query count

6d04a55

Update UI snapshots for chromium (1)

0a388e1

daibhin added 2 commits April 14, 2025 08:48

Merge branch 'master' into dn-chore/update-manual-exception-capture-c…

4d4e69a

…alls

Merge branch 'dn-chore/update-manual-exception-capture-calls' of gith…

72828c4

…ub.com:PostHog/posthog into dn-chore/update-manual-exception-capture-calls

daibhin commented Apr 14, 2025

View reviewed changes

hpouillot reviewed Apr 14, 2025

View reviewed changes

add team id

5ee604e

daibhin enabled auto-merge (squash) April 14, 2025 08:11

daibhin merged commit b8b58d9 into master Apr 14, 2025
109 of 110 checks passed

daibhin deleted the dn-chore/update-manual-exception-capture-calls branch April 14, 2025 08:38

lricoy pushed a commit that referenced this pull request Apr 14, 2025

chore: manual exception capture calls (#31135)

ee1041a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: manual exception capture calls #31135

chore: manual exception capture calls #31135

daibhin commented Apr 11, 2025

greptile-apps bot left a comment

greptile-apps bot Apr 11, 2025

greptile-apps bot Apr 11, 2025

greptile-apps bot Apr 11, 2025

greptile-apps bot Apr 11, 2025

zlwaterfield left a comment

posthog-bot commented Apr 11, 2025

posthog-bot commented Apr 11, 2025

github-actions bot commented Apr 11, 2025 •

edited

Loading

posthog-bot commented Apr 11, 2025

daibhin Apr 14, 2025

hpouillot left a comment

hpouillot Apr 14, 2025

	from exceptions import capture_exception
	from posthog.exceptions import capture_exception

chore: manual exception capture calls #31135

chore: manual exception capture calls #31135

Conversation

daibhin commented Apr 11, 2025

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

greptile-apps bot Apr 11, 2025

Choose a reason for hiding this comment

greptile-apps bot Apr 11, 2025

Choose a reason for hiding this comment

greptile-apps bot Apr 11, 2025

Choose a reason for hiding this comment

greptile-apps bot Apr 11, 2025

Choose a reason for hiding this comment

zlwaterfield left a comment

Choose a reason for hiding this comment

posthog-bot commented Apr 11, 2025

📸 UI snapshots have been updated

posthog-bot commented Apr 11, 2025

📸 UI snapshots have been updated

github-actions bot commented Apr 11, 2025 • edited Loading

posthog-bot commented Apr 11, 2025

📸 UI snapshots have been updated

daibhin Apr 14, 2025

Choose a reason for hiding this comment

hpouillot left a comment

Choose a reason for hiding this comment

hpouillot Apr 14, 2025

Choose a reason for hiding this comment

github-actions bot commented Apr 11, 2025 •

edited

Loading