Skip to content

feat: unstacking the exposure chart. #31134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2025

Conversation

rodrigoi
Copy link
Contributor

Important

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Problem

A little update to unstack the exposure time series data. It looks cumulative when it's not.

Changes

Before After
image image

Does this work well for both Cloud and self-hosted?

How did you test this code?

@rodrigoi rodrigoi requested a review from a team April 11, 2025 16:08
@rodrigoi rodrigoi self-assigned this Apr 11, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR modifies the Exposures component to unstack the experiment exposure chart, displaying independent line series instead of stacked areas for better data representation.

  • Changed fill: true to fill: false in the dataset configuration to remove area filling under lines
  • Removed stack: 'stack1' property from the dataset configuration to prevent stacking
  • Removed stacked: true from the y-axis scale configuration to ensure independent series display
  • Maintained accurate tooltip description that correctly refers to "daily cumulative count of unique users"

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@rodrigoi rodrigoi enabled auto-merge (squash) April 11, 2025 16:12
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

  • chromium: 0 added, 4 modified, 0 deleted (diff for shard 7)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Contributor

Size Change: +74 B (0%)

Total Size: 13.2 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 13.2 MB +74 B (0%)

compressed-size-action

Copy link
Contributor

@andehen andehen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I think this is better. If the distributions are similar, it's easy to spot that the rollout behave as it should if they are exactly similar. If it's stacked, it's not.

But not a strong opinion though, if anyone disagrees.

(and as we talked about, putting this under a tab makes sense. I think results should be the first the user sees)

@rodrigoi rodrigoi merged commit 3a9942c into master Apr 11, 2025
108 of 109 checks passed
@rodrigoi rodrigoi deleted the experiments/exposure-chart-unstacked branch April 11, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants