refactor: split out persons postgres #31099
Open
+336
−348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR refactors the PostHog plugin server to support a separate PostgreSQL database for person data, enabling better scalability and separation of concerns.
- Added new configuration variables
PERSONS_DATABASE_URLandPERSONS_READONLY_DATABASE_URLwith appropriate defaults - Introduced new
PostgresUseenum values (PERSONS_READ and PERSONS_WRITE) for directing queries to the correct database - Updated all person-related database operations to use the new database connection types
- Removed the broken
doesPersonBelongToCohortquery and simplified cohort matching logic - Modified CI workflows and Docker configuration to support testing with the new database architecture
13 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+143
to
+144
| PERSONS_DATABASE_URL: string // Optional read-write Postgres database for persons | ||
| PERSONS_READONLY_DATABASE_URL: string // Optional read-only replica to the persons Postgres database |
There was a problem hiding this comment.
logic: The description says "Optional" but the type doesn't reflect this - should this be string | null to match other optional database URLs in the config?
Suggested change
| PERSONS_DATABASE_URL: string // Optional read-write Postgres database for persons | |
| PERSONS_READONLY_DATABASE_URL: string // Optional read-only replica to the persons Postgres database | |
| PERSONS_DATABASE_URL: string | null // Optional read-write Postgres database for persons | |
| PERSONS_READONLY_DATABASE_URL: string | null // Optional read-only replica to the persons Postgres database |
Comment on lines
+89
to
+98
| if (serverConfig.PERSONS_READONLY_DATABASE_URL) { | ||
| logger.info('🤔', `Connecting to persons read-only Postgresql...`) | ||
| this.pools.set( | ||
| PostgresUse.PERSONS_READ, | ||
| createPostgresPool( | ||
| serverConfig.PERSONS_READONLY_DATABASE_URL, | ||
| serverConfig.POSTGRES_CONNECTION_POOL_SIZE, | ||
| app_name | ||
| ) | ||
| ) |
There was a problem hiding this comment.
logic: Missing success log message after connecting to persons read-only PostgreSQL. All other connection blocks have a success message, but this one doesn't.
Suggested change
| if (serverConfig.PERSONS_READONLY_DATABASE_URL) { | |
| logger.info('🤔', `Connecting to persons read-only Postgresql...`) | |
| this.pools.set( | |
| PostgresUse.PERSONS_READ, | |
| createPostgresPool( | |
| serverConfig.PERSONS_READONLY_DATABASE_URL, | |
| serverConfig.POSTGRES_CONNECTION_POOL_SIZE, | |
| app_name | |
| ) | |
| ) | |
| if (serverConfig.PERSONS_READONLY_DATABASE_URL) { | |
| logger.info('🤔', `Connecting to persons read-only Postgresql...`) | |
| this.pools.set( | |
| PostgresUse.PERSONS_READ, | |
| createPostgresPool( | |
| serverConfig.PERSONS_READONLY_DATABASE_URL, | |
| serverConfig.POSTGRES_CONNECTION_POOL_SIZE, | |
| app_name | |
| ) | |
| ) | |
| logger.info('👍', `Persons read-only Postgresql ready`) | |
| } |
benjackwhite
approved these changes
Apr 11, 2025
Comment on lines
+143
to
+144
| PERSONS_DATABASE_URL: string // Optional read-write Postgres database for persons | ||
| PERSONS_READONLY_DATABASE_URL: string // Optional read-only replica to the persons Postgres database |
There was a problem hiding this comment.
Suggested change
| PERSONS_DATABASE_URL: string // Optional read-write Postgres database for persons | |
| PERSONS_READONLY_DATABASE_URL: string // Optional read-only replica to the persons Postgres database | |
| PERSONS_DATABASE_URL?: string // Optional read-write Postgres database for persons | |
| PERSONS_READONLY_DATABASE_URL?: string // Optional read-only replica to the persons Postgres database |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Problem
We're moving persons out of the main postgres and we need to point plugin-server to both databases.
Changes
Does this work well for both Cloud and self-hosted?
Yes, might need to review the setup docs
How did you test this code?
Using existing tests
Will validate on dev first