feat(crm): Second pass at overview dashboard #31079
Conversation
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
danielbachhuber
changed the title
danielbachhuber
changed the title
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR enhances the group detail view with a redesigned Overview tab that provides a more comprehensive and modular information display.
- Added three new card components (
GroupDashboardCard,GroupPeopleCard,GroupPropertiesCard) to display insights, related people, and properties in a structured layout - Refactored
GroupOverview.tsxto use these card components instead of just showing a dashboard or creation prompt - Modified
RelatedGroupscomponent to support filtering by type and limiting results - Updated
dashboard_templates.pyto create better insights with 90-day timeframes and full-width tiles - Set 'Overview' as the default tab in the group detail view for improved user experience
8 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
| </div> | ||
| </div> | ||
| <div> | ||
| <h2>Insights</h2> | ||
| <GroupDashboardCard /> |
There was a problem hiding this comment.
logic: GroupDashboardCard is used without passing groupData prop, but the component might need it based on its implementation in GroupDashboardCard.tsx
There was a problem hiding this comment.
This component is reading from the logic
| onClick={() => { | ||
| setCreatingDetailDashboard(true) | ||
| reportGroupTypeDetailDashboardCreated() | ||
| createDetailDashboard(groupData.group_type_index) | ||
| }} |
There was a problem hiding this comment.
style: Consider adding error handling for the createDetailDashboard call to reset the creatingDetailDashboard state if the operation fails.
| <div className="flex flex-col gap-2"> | ||
| <PropertiesTable | ||
| type={PropertyDefinitionType.Group} | ||
| properties={propertySummary || {}} |
There was a problem hiding this comment.
style: The fallback to empty object here is redundant since line 15 already has a fallback with || {}
| properties={propertySummary || {}} | |
| properties={propertySummary} |
|
Size Change: +105 B (0%) Total Size: 13.2 MB ℹ️ View Unchanged
|
See #29881
Design discussion in https://posthog.slack.com/archives/C08GGECGJF4/p1744301304806079
Changes
Second pass at the 'Overview' tab in the group detail context. Also sets 'Overview' as the default tab.
CleanShot.2025-04-10.at.16.02.59.mp4
The insight doesn't default to full width because of this funkiness:
posthog/frontend/src/scenes/dashboard/dashboardLogic.tsx
Lines 326 to 328 in b708bc3
How did you test this code?
Refreshed the page a lot.