Skip to content

fix(bi): Fixed tabels not scrolling #31075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2025
Merged

Conversation

Gilbert09
Copy link
Member

Problem

Changes

  • Remove the h-full class I added yday, but only for tables

@Gilbert09 Gilbert09 requested a review from a team April 10, 2025 16:01
@Gilbert09 Gilbert09 enabled auto-merge (squash) April 10, 2025 16:01
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR fixes a scrolling issue in DataViz tables by conditionally applying the h-full class to visualization containers.

  • Modified InternalDataTableVisualization component in frontend/src/queries/nodes/DataVisualization/DataVisualization.tsx to exclude the h-full class specifically for table visualizations
  • Uses clsx utility to conditionally apply styling based on visualization type
  • Allows tables to properly scroll while maintaining full height for other visualization types
  • Addresses a reported issue where DataViz tables could no longer scroll

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

Size Change: +6 B (0%)

Total Size: 13.2 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 13.2 MB +6 B (0%)

compressed-size-action

@Gilbert09 Gilbert09 merged commit 0f762f0 into master Apr 10, 2025
109 of 110 checks passed
@Gilbert09 Gilbert09 deleted the tom/fix-tables-not-scrolling branch April 10, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants