fix(batch-exports): Handle cancellation of activities #31063
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently whenever batch export Temporal activities timeout or are cancelled the SPMC consumer task continues to run in the background. This consumes additional resources in ClickHouse and whatever external destination it is exporting data to.
Changes
Ensure the record batch consumer is cancelled if the activity itself is cancelled by Temporal.
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Extensive testing locally