fix(err): allow notifications to be edited #31043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @oliverb123! 👋 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR enables editing of error tracking notification templates across multiple platforms and adds testing capabilities to the error tracking alert UI.
- Modified
/frontend/src/scenes/error-tracking/configuration/alerting/ErrorTrackingAlert.tsxto enable testing configuration by settinghideTestingConfiguration: false - Updated notification templates in Slack, Discord, and Microsoft Teams to make message content fields visible and editable by changing
hidden: Falsein their respective template files - Modified
/frontend/src/scenes/pipeline/hogfunctions/hogFunctionConfigurationLogic.tsxto conditionally exclude person data for error tracking notifications - Improved error tracking notification customization by exposing previously hidden fields in the UI for better user control
Greptile AI
5 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
frontend/src/scenes/pipeline/hogfunctions/hogFunctionConfigurationLogic.tsx
Show resolved
Hide resolved
|
Size Change: +14 B (0%) Total Size: 13.2 MB ℹ️ View Unchanged
|
oliverb123
force-pushed
the
err/allow-block-modification-and-testing
branch
from
6e8dd91 to
888cf85
Compare
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
hpouillot
approved these changes
Apr 10, 2025
lricoy
pushed a commit
that referenced
this pull request
Apr 14, 2025
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.