-
Notifications
You must be signed in to change notification settings - Fork 1.6k
fix: remove funnel trends incorrect heuristic #31041
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR fixes a bug in funnel trends analysis by removing the event filtering heuristic that was causing issues with unordered trends having multiple first steps across different time intervals.
- Removed the
udf_event_array_filter
method fromfunnel_trends_udf.py
and now passes the rawevents_array
directly to the funnel aggregation function - Added a comprehensive test case in
test_funnel_unordered.py
that verifies correct conversion rates for users with varying event patterns across multiple days - The fix is particularly important for unordered funnels where any event can be the first step, making the previous filtering approach problematic
- Test creates 5 users with different patterns of event occurrences to thoroughly validate the solution works across various scenarios
- Addresses a customer-reported issue where trends analysis was breaking when events spanned different time intervals
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
…thog into aspicer/unordered_trends_bug
anirudhpillai
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Event filtering heuristic breaks for trends that have multiple first steps in a row that fall in different intervals. This is especially bad in unordered trends, because any event can be the first event.
Reported here: https://posthog.slack.com/archives/C045L1VEG87/p1744047732992239
Changes
Remove the event filtering for trends
How did you test this code?
Wrote a test for it.