feat(propdefs): override team_id & project_id if inbound raw Event includes root_team_id #31032
+41
−27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
New environments handling has replaced
project_id
with a notion of parent ("root") team ID which controls the global property def type classifications and other settings for all child teams.We need the
⚠️ DO NOT MERGE until environments prep work is completed ⚠️
property-defs-rs
service to becomeroot_team_id
aware as part of the transition.Changes
Event
s overrideteam_id
andproject_id
when decomposed intoUpdate
s wheneverEvent#root_team_id
is presentteam_id
in the property defs API where project_id was neededTODO: remove uses of
COALESCE
onproject_id
, falling back toteam_id
, relying on (overridden)team_id
in allproperty-defs-rs
SQLDoes this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Locally and in CI; coordinated w/ @benjackwhite 's ongoing environments work