Skip to content

chore: updates the PR template coding conventions message #31027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

rodrigoi
Copy link
Contributor

@rodrigoi rodrigoi commented Apr 9, 2025

Important

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Problem

A small change to the PR template to use an alert to link to the Coding Convetions documentation.

Changes

Before After
Screenshot 2025-04-09 at 16 51 57 Screenshot 2025-04-09 at 16 51 13

Does this work well for both Cloud and self-hosted?

How did you test this code?

@rodrigoi rodrigoi self-assigned this Apr 9, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Updated the PR template to include a prominent, GitHub callout-style alert reminding contributors to stay updated with PostHog coding conventions, while redundant duplicate alerts have been removed.

  • Modified file: .github/pull_request_template.md to add an important alert.
  • Implemented GitHub callout syntax linking to PostHog coding conventions.
  • Removed duplicate alert for cleaner, consolidated guidance.

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@rodrigoi rodrigoi changed the title chore: updates the PR template to use an important alert for code rev… chore: updates the PR template coding conventions message Apr 9, 2025
@rodrigoi rodrigoi merged commit 4158399 into master Apr 9, 2025
97 checks passed
@rodrigoi rodrigoi deleted the chore/adds-important-alert-for-code-review-documentation branch April 9, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants