fix(insights): Do not close UnitPicker modal when clicking inside it #31024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR refactors the custom unit modal in UnitPicker to address unexpected dropdown closures by moving the modal to a global level.
- Introduced
/frontend/src/lib/components/UnitPicker/GlobalCustomUnitModal.tsxto handle modal rendering globally. - Updated
/frontend/src/lib/components/UnitPicker/UnitPicker.tsxto trigger modal actions via the new global logic. - Added
/frontend/src/lib/components/UnitPicker/unitPickerModalLogic.tsfor centralized modal state management. - Removed the obsolete
/frontend/src/lib/components/UnitPicker/CustomUnitModal.tsxcomponent. - Integrated the global modal in
/frontend/src/layout/GlobalModals.tsx.
5 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
Size Change: -282 B (0%) Total Size: 13.2 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The UnitPicker component has a modal interaction issue where clicking inside the Custom prefix/postfix modal causes the parent dropdown to close unexpectedly. This happens because the modal is rendered in a Portal (outside the DOM hierarchy), but the dropdown's click detection still registers clicks inside the modal as "outside clicks" that should close the dropdown.
The issue creates a frustrating user experience as users are unable to effectively configure custom units for their visualizations.
Closes #31011
Changes
The solution completely redesigns the modal architecture to use global state management instead of relying on DOM event propagation:
This approach is more robust because it completely avoids the event bubbling conflicts by separating the modal from the dropdown DOM hierarchy.
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Tested locally and it works, should not change code that affects any other components but this custom modal.