feat: Use dot notation for revenue views #31016
Conversation
Following https://github.com/PostHog/posthog/pull/30947/files let's also make the revenue views use dot notation. This will make them fit slightly better.
| if source.prefix is None: | ||
| name = f"stripe.revenue_view" | ||
| else: | ||
| prefix = source.prefix.strip("_") | ||
| name = f"stripe.{prefix}.revenue_view" |
There was a problem hiding this comment.
It's always stripe for now, so I don't mind hardcoding this, will eventually need to make this a little bit more dynamic
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Overall, the PR updates revenue view naming to adopt dot notation consistently across the codebase, affecting data source prefixes, query construction, and view assignment logic.
- Modified
/products/revenue_analytics/backend/models.pyto generate RevenueAnalyticsRevenueView names with dot notation, noting a potential double dot if source.prefix is empty. - Updated
/posthog/hogql/database/database.pyto use the view’s name attribute for revenue view assignment instead of concatenating strings. - Changed
/products/revenue_analytics/backend/hogql_queries/revenue_example_data_warehouse_tables_query_runner.pyto build queries with unqualified field references aligning with dot notation. - Adjusted prefix settings in
/posthog/warehouse/test/utils.pyto remove an underscore suffix.
4 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| if source.prefix is None: | ||
| name = f"stripe.revenue_view" | ||
| else: | ||
| prefix = source.prefix.strip("_") | ||
| name = f"stripe.{prefix}.revenue_view" |
There was a problem hiding this comment.
logic: Empty prefix ("") will lead to 'stripe..revenue_view'. Consider checking for falsy values instead of 'is None'.
| if source.prefix is None: | |
| name = f"stripe.revenue_view" | |
| else: | |
| prefix = source.prefix.strip("_") | |
| name = f"stripe.{prefix}.revenue_view" | |
| if not source.prefix: | |
| name = f"stripe.revenue_view" | |
| else: | |
| prefix = source.prefix.strip("_") | |
| name = f"stripe.{prefix}.revenue_view" |
There was a problem hiding this comment.
This is needed - prefix can be ""
There was a problem hiding this comment.
Ah, nice, fixed it + added some tests
e7dedd7
| if source.prefix is None: | ||
| name = f"stripe.revenue_view" | ||
| else: | ||
| prefix = source.prefix.strip("_") | ||
| name = f"stripe.{prefix}.revenue_view" |
There was a problem hiding this comment.
This is needed - prefix can be ""
Added some tests to prove it works
Following https://github.com/PostHog/posthog/pull/30947/files let's also make the revenue views use dot notation. This will make them fit slightly better.