feat: Retry Clickhouse queries in Dagster jobs if they fail due to cluster-wide memory limits #31015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uster-wide memory limit
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
The changes implement a retry mechanism in Dagster jobs to handle Clickhouse queries failing due to cluster-wide memory limits. This distinction ensures that only transient cluster memory issues trigger a retry.
- Modified
/dags/common.pyto include a lambda function detecting "Memory limit (total) exceeded" errors. - Distinguishes retries for cluster-wide memory limits versus single query limits.
- Improves system resiliency by automatically retrying affected queries.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
timgl
approved these changes
Apr 9, 2025
orian
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Sometimes administrative queries fail because other queries on the server are eating all the memory, e.g. https://dagster.prod-eu.posthog.dev/runs/57d97122-b477-43e1-a4db-02570906aea7
Changes
Retries queries if they are killed due to server-wide memory limits. Queries are not retried if they exceed single query memory limits.
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
🙃