Skip to content

fix(project-tree): show checkbox on hover if no checked items #31003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2025

Conversation

adamleithp
Copy link
Contributor

Problem

Select only in the context menu was too hidden

2025-04-09 16 02 00

Changes

Show the select checkbox on hover of any item's icon if no other item is checked to start multiselect mode.

How did you test this code?

Locally

@adamleithp adamleithp requested a review from mariusandra April 9, 2025 15:03
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR refines the project tree multi-select experience by ensuring a checkbox appears on hover when no items are checked, streamlining user actions.

  • Updated hover logic in frontend/src/lib/lemon-ui/LemonTree/LemonTree.tsx to trigger checkbox appearance via the consolidated TreeNodeDisplayIconWrapper.
  • Adjusted CSS and padding in frontend/src/lib/lemon-ui/LemonTree/LemonTreeUtils.tsx to better position the checkbox.
  • Improved click handling and consistent propagation of the checkedItemCount prop for reliable multi-selection interactions.

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 3)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Contributor

github-actions bot commented Apr 9, 2025

Size Change: 0 B

Total Size: 13.2 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 13.2 MB

compressed-size-action

@mariusandra mariusandra merged commit 849be96 into master Apr 9, 2025
110 checks passed
@mariusandra mariusandra deleted the devex/tree-show-checkbox branch April 9, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants