feat: Display count of persons for early access features #30966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bothered me so I fixed it. Previously we had to keep clicking until we had loaded *all* of the users because we could see how many had enabled access to our feature, we're now displaying it at the top.
rafaeelaudibert
commented
Apr 8, 2025
Comment on lines
+103
to
+118
| const results = await Promise.all( | ||
| ['true', 'false'].map((value) => | ||
| performQuery<ActorsQuery>({ | ||
| kind: NodeKind.ActorsQuery, | ||
| properties: [ | ||
| { | ||
| key: values.featureEnrollmentKey, | ||
| type: PropertyFilterType.Person, | ||
| operator: PropertyOperator.Exact, | ||
| value: [value], | ||
| }, | ||
| ], | ||
| select: ['count()'], | ||
| }) | ||
| ) | ||
| ) |
There was a problem hiding this comment.
Maybe I could do this with a single query and a breakdown? I don't know enough about our queries to know that yet, happy to change if that's possible
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Overall, this PR refactors the early access feature UI to dynamically display the count of opted-in and opted-out users by integrating a new loader into the existing logic.
- Updated user count labels in
products/early_access_features/frontend/EarlyAccessFeature.tsx(LemonTabs labels now show counts). - Added a new
personsCountloader with breakpoint delays inproducts/early_access_features/frontend/earlyAccessFeatureLogic.ts. - Renamed the filtering helper to
featureFlagRecordingEnrolmentFilterfor clarity. - Ensured consistent integration with async queries and state management for dynamic updates.
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
Size Change: +670 B (+0.01%) Total Size: 13.2 MB ℹ️ View Unchanged
|
haacked
approved these changes
Apr 8, 2025
products/early_access_features/frontend/earlyAccessFeatureLogic.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This bothered me, so I fixed it. Previously, we had to keep clicking until we had loaded all of the users because we could see how many had enabled access to our feature.
Changes
Query and display the count 🤷🏻
Does this work well for both Cloud and self-hosted?
Yeap
How did you test this code?
Manual