chore: quota limiting updates #30965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zlwaterfield
requested review from
Gilbert09,
tomasfarias,
pawel-cebula and
patricio-posthog
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR modifies the quota limiting workflow, updating both the schedule frequency and retry strategy while ensuring related deployments are triggered correctly.
- Updated regex in
.github/workflows/container-images-cd.ymlto include^posthog/temporal/quota_limitingfor triggering deployments. - Changed cron schedule in
/posthog/temporal/schedule.pyfrom a 30-minute interval to"10,30,50 * * * *", increasing the job frequency. - Reduced retry attempts for
run-quota-limitingin/posthog/temporal/quota_limiting/run_quota_limiting.pyfrom 3 to 2.
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
pawel-cebula
approved these changes
Apr 9, 2025
Gilbert09
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This job is running faster now so running it more often.
Also adding to the watch list for deploys.
And lower retrys because we don't need 3.