chore: make page reports ui more compact #30963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Overall, the PR refines the Page Reports UI to be more compact by adjusting layouts and reducing vertical spacing.
- /frontend/src/scenes/web-analytics/PageReports.tsx: Added a "compact" prop to the Tiles component and adjusted container CSS classes (using
h-fullandmin-h-0) to stabilize the layout during loading. - /frontend/src/scenes/web-analytics/WebAnalyticsDashboard.tsx: Modified margins and conditional separators to better suit a compact display.
- /frontend/src/scenes/web-analytics/pageReportsLogic.ts: Updated tile layouts with consistent minimum heights and reduced extra titles.
- /frontend/src/scenes/web-analytics/webAnalyticsLogic.tsx: Made SectionTile titles optional to remove unnecessary UI clutter.
4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
📸 UI snapshots have been updated5 snapshot changes in total. 0 added, 5 modified, 0 deleted:
Triggered by this commit. |
|
Size Change: -64 B (0%) Total Size: 13.2 MB ℹ️ View Unchanged
|
robbie-c
approved these changes
Apr 9, 2025
I will do that on another PR after the other UI fixes in the spirit of the current brown bag :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR approaches a combination of UI feedbacks on the page reports here.
Changes
Configuring a more compact UI with less vertical space, no titles or separators and making all tiles have a minimum height.
It was not enough to use a flex layout like in the web analytics dashboard because the multiple loading states were conflicting among them and it would still shift when some tables have less data than others after they are loaded.
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Manually.