feat(propdefs-v2): inline batch writes when any batch bucket is full #30959
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Seeing some problems with v2 batch writes in
prod-us
at high event volume, even using larger batches, with the internal queue backing up. I think this is a result of passing along all the batches totokio::spawn
before awaiting any handles to complete.Changes
Just to see how it behaves in next deploy test. Next thing to try: inline all (most?) batch writes in the main thread.
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Locally and in CI; once merged, in deploy test and observation