feat(crm): Incorporate B2B analytics into tree-nav #30930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR updates the navigation components to support B2B analytics by conditionally rendering labels and side actions. It adjusts the UI to show "Persons and cohorts" and adds a beta tag when the B2B analytics flag is enabled.
- Updated
/frontend/src/layout/panel-layout/PanelLayoutNavBar.tsxto conditionally change the label and tooltip for the PersonsManagement nav item. - Modified
/frontend/src/layout/panel-layout/panelLayoutLogic.tsxto add thesetVisibleSideActionaction. - Adjusted
/frontend/src/layout/navigation-3000/navigationLogic.tsxto inject the B2B analytics nav item with a beta tag.
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
mariusandra
approved these changes
Apr 8, 2025
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
|
Size Change: +40 B (0%) Total Size: 13.1 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #29881
Changes
Renders the 'B2B analytics' side action and changes the 'People and groups' label when
b2b-analyticsis enabledb2b-analytics disabled
b2b-analytics enabled
How did you test this code?
Visual review.