fix(project-tree): spinner when moving #30923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamleithp
approved these changes
Apr 8, 2025
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR improves the project tree by displaying spinner feedback during item moves while streamlining the queueing logic.
- Added spinner indicators in move operations for immediate visual feedback in
/frontend/src/layout/panel-layout/ProjectTree/projectTreeLogic.tsx. - Ensured consistent removal of queued actions across move, link, create, and delete flows.
- Adjusted API handling in both success and error paths to prevent stale spinners.
- Highlighted risk of race conditions when multiple actions are queued for further testing.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
|
Size Change: +231 B (0%) Total Size: 13.1 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When moving items there's no visual feedback until after an item is moved
Changes
Bring back the spinners that were there before (note: my connection here is throttled)
How did you test this code?
See screencast