chore: remove cutoff condition for activation sidepanel #30916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR simplifies the logic for displaying the Activation tab by removing a fixed cutoff date and now only relying on a 30-day age check based on each team's creation date.
- Updated
/frontend/src/layout/navigation-3000/sidepanel/sidePanelLogic.tsxto remove the fixed date cutoff and solely use the team age. - Ensured the 30-day threshold governs the Activation tab display.
- Maintained the use of the
shouldShowActivationTabflag for overall visibility control.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
Size Change: -244 B (0%) Total Size: 10.2 MB ℹ️ View Unchanged
|
zlwaterfield
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Activation sidepanel was using a cutoff for existing teams for first 30 days
Changes
No longer needed, just cleans it up.
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Ran locally