fix: delay invite task completion to after onboarding completed #30915
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When a user invites someone and submits onboarding they need to click twice.
Changes
Tried to get to the bottom of why this is happening for a while, for some reason the update to mark the onboarding task as completed conflicts with the update to complete onboarding, and the loader in kea overwrites the team as having not completed onboarding.
After a while trying to fix that, just added a timeout to fix the race condition.
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Ran it locally