fix: make sure quota limiting fields are set #30911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR refactors how the quota limiting fields are updated in an organization's usage summary by batching updates, reducing redundant database calls, and ensuring consistency.
- Refactored quota limiting updates in ee/billing/quota_limiting.py to use a batched call via update_organization_usage_fields.
- Updated helper to delete keys when values are None, aligning with expected behavior.
- Improved consistency in updating both quota_limited_until and quota_limiting_suspended_until fields.
- Maintained existing quota limiting logic while optimizing database interactions.
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We are not explicitly setting the quota limiting fields on the organization usage, and it looks like there is an error from that.
This adds quote a few db calls so we may want to improve the efficiency here somehow.
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
It doesn't have an impact.
How did you test this code?
Will add tests