feat(propdefs): Stricter classification of DateTime values #30908
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We don't want to accidentally classify large numerical values as
DateTime
if they happen to match a UNIX timestamp in the last 6 month window.Changes
Restrict numerical valued
DateTime
classifications to be both a valid UNIX timestamp in the last 6 months and include one of the "timestamp keywords" in the property name.All other numerical valued props will be classified as
Numeric
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Locally and in CI