fix: not all valid css selectors are valid for action matching #30903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR fixes issues with CSS selector generation for action matching in PostHog by leveraging native CSS.escape and patching the selector output to handle Tailwind CSS classes with escaped characters.
- Updated
/frontend/src/lib/utils/cssEscape.tsto directly aliasCSS.escapeinstead of using a custom implementation. - Patched regex in
/frontend/src/toolbar/utils.tsto remove backslashes in data attribute selectors, ensuring compatibility with action matching.
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
Size Change: +110 B (0%) Total Size: 10.2 MB ℹ️ View Unchanged
|
pauldambra
requested review from
anirudhpillai,
a team,
sortafreel and
veryayskiy
and removed request for
a team
sortafreel
reviewed
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://posthoghelp.zendesk.com/agent/tickets/28216
and
#15480
the toolbar uses the mdev/finder library to generate CSS selectors it might generate a valid CSS selector that we can't use in action matching. this is because it escapes CSS but our action matcher doesn't understand (all? some?) escaped CSS
i don't want to write a CSS unescaper targetting our action matching, that feels like a fool's game
let's just patch this case we know about