feat: Add Revenue Analytics v0 #30895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaeelaudibert
added
team/revenue-analytics
feature/revenue-analytics
rafaeelaudibert
requested review from
EDsCODE,
a team,
lricoy,
robbie-c and
jabahamondes
and removed request for
a team
rafaeelaudibert
force-pushed
the
revenue-analytics-v0-attempt-2
branch
from
fc8a40c to
bcbe43b
Compare
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR kickstarts Revenue Analytics v0 by refactoring revenue configuration, navigation, and API mocks while removing deprecated data warehouse settings.
- Updated revenue URL in
/frontend/src/layout/panel-layout/ProjectTree/defaultTree.tsxfromurls.revenue()tourls.revenueSettings(). - Removed
dataWarehouseTablesfromMOCK_DEFAULT_TEAMin/frontend/src/lib/api.mock.tsto consolidate revenue event settings. - Added a new navigation item with
IconPiggyBankin/frontend/src/layout/navigation-3000/navigationLogic.tsx, gated by the REVENUE_ANALYTICS feature flag. - Introduced a new workspace dependency for Revenue Analytics in
/frontend/package.jsonand adjusted schema types in/frontend/src/queries/schema/schema-general.ts. - Configured new scene mapping and URL changes in
/frontend/src/scenes/appScenes.tsand/frontend/src/scenes/urls.tsfor integration of the Revenue Analytics feature.
55 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
...lytics/backend/hogql_queries/test/test_revenue_example_data_warehouse_tables_query_runner.py
Show resolved
Hide resolved
EDsCODE
approved these changes
Apr 7, 2025
| } | ||
|
|
||
|
|
||
| class RevenueAnalyticsRevenueView(SavedQuery): |
...evenue_analytics/backend/hogql_queries/revenue_example_data_warehouse_tables_query_runner.py
Show resolved
Hide resolved
rafaeelaudibert
added a commit
that referenced
this pull request
Apr 7, 2025
Testing queries against data warehouse tables is extremely hard right now. We're doing it in different ways in different places. Let's standardize it by providing a common interface we can use everywhere: CSV files + single function to handle creating tables, sources, credentials, etc. Extracted from #30895
rafaeelaudibert
force-pushed
the
revenue-analytics-v0-attempt-2
branch
2 times, most recently
from
96aa010 to
cdaeb57
Compare
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
|
Size Change: -7.69 kB (-0.06%) Total Size: 13.2 MB
|
rafaeelaudibert
force-pushed
the
revenue-analytics-v0-attempt-2
branch
from
a0088b2 to
7665286
Compare
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
This our first attempt at Revenue Analytics. This is just the initial setup, configuring all of the file structure and attempting at using a virtual `view` to display this inside PostHog. We arent adding any charts yet, this is coming soon. We'll probably need to create cross-table views (for invoices and charges) but that's coming in a future PR, this is only the first PR to get an idea from the Data Warehouse team whether this makes any sense or not
Most werent necessary anymore, we've simplified the workflow by a lot now
Update query snapshots Update query snapshots Update UI snapshots for `chromium` (5) Update UI snapshots for `chromium` (5) Update UI snapshots for `chromium` (5) Update UI snapshots for `chromium` (5) Update UI snapshots for `chromium` (5)
rafaeelaudibert
force-pushed
the
revenue-analytics-v0-attempt-2
branch
from
96a9406 to
2c3849f
Compare
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
rafaeelaudibert
force-pushed
the
revenue-analytics-v0-attempt-2
branch
from
90d7b54 to
aa15cd9
Compare
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
There's one extra query now to check for Stripe sources
rafaeelaudibert
force-pushed
the
revenue-analytics-v0-attempt-2
branch
from
59f6162 to
1c4e1c4
Compare
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
Turns out increasing the number of queries in the test file was wrong, let's remove all of the N+1 queries
rafaeelaudibert
force-pushed
the
revenue-analytics-v0-attempt-2
branch
from
ca5a1bc to
6c2fb5d
Compare
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
lricoy
approved these changes
Apr 8, 2025
| "products.early_access_features", | ||
| "products.editor", | ||
| "products.revenue_analytics", |
There was a problem hiding this comment.
Just a note to check if the style changes are due to a local or different formatter; nothing is required on this PR.
|
Nice! I trust your changes; I did some quick local explorations on the pats I am familiar with, but they are very shallow. |
rafaeelaudibert
force-pushed
the
revenue-analytics-v0-attempt-2
branch
from
c0cf4d5 to
6346d07
Compare
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
hpouillot
pushed a commit
that referenced
this pull request
Apr 9, 2025
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This our first attempt at Revenue Analytics. This is just the initial setup, configuring all of the file structure and attempting at using a virtual
viewto display this inside PostHog. We arent adding any charts yet, this is coming soon.We'll probably need to create cross-table views (for invoices and charges), but that's coming in a future PR. This is only the first PR to get an idea from the Data Warehouse team whether this makes any sense or not
Supersedes #30704