feat: Quick link to matching events from unidentified person #30886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR introduces quick access to matching events from unidentified person contexts by adding "View events" buttons across key components.
- In /frontend/src/scenes/persons/PersonScene.tsx, the NotFound component is now passed a
metaprop withurlIdfor filtered event access. - In /frontend/src/scenes/persons/PersonPreview.tsx, a new "View events" button is added for scenarios when the person is not found.
- In /frontend/src/lib/components/NotFound/index.tsx, the component renders a "View events" button using
meta?.urlIdto create a filtered events query.
3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
|
Size Change: +737 B (+0.01%) Total Size: 13.2 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
raquelmsmith
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds "View events" buttons to "Person not found" contexts.
How did you test this code?
I clicked on the links and verified they went to the expected filtered views.